Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric zero,one, WrappedArray.{sum,product} #69

Open
wants to merge 3 commits into
base: 2.12.x
Choose a base branch
from
Open

Numeric zero,one, WrappedArray.{sum,product} #69

wants to merge 3 commits into from

Conversation

retronym
Copy link
Owner

No description provided.

@mkeskells
Copy link

mkeskells commented Aug 30, 2019 •
edited
Loading

Can we also consider min and max
They are both allocation heavy for boxing doubles from Arrays

mkeskells
mkeskells reviewed Aug 30, 2019
View reviewed changes
src/library/scala/collection/mutable/WrappedArray.scala
}
z
} else {
super.sum[B]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be super.sum(num)
avoid any implicit that may be in scope, and avoid the implicit scan
and for me - makes it more obvious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeskells mkeskells mkeskells left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retronym @mkeskells